Make site and resource niceId editable #1767
Open
+168
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pallavikumarimdb
force-pushed
the
feat/make-niceId-editable
branch
from
8bcfdb8 to
0c5d1a2
Compare
|
Hi @Pallavikumarimdb sorry about this. Having looked at the implementation when in the top card we think it will be better in the general form under the name as an input. Could you make that change? We liked it at the top but decided it would be more application consistent in the general form on both the site and the resources. 
|
Pallavikumarimdb
force-pushed
the
feat/make-niceId-editable
branch
from
0c5d1a2 to
fb9bc22
Compare
|
@oschwartz10612 , I’ve made the change. Could you please review again? |
Pallavikumarimdb
force-pushed
the
feat/make-niceId-editable
branch
from
026a911 to
d718f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
How to test?