-
-
Notifications
You must be signed in to change notification settings - Fork 465
Fix upgrade zod from 3.25.76 to 4.1.12 #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey @Lokowitz sorry for all of the changes yanked up from saas which probably require a rebase... and for my delay. LMK if you need me to rebase. As usually thanks for doing this kind of work its incredibly helpful!
I think we probably should validate an IP input is either v4 or v6 as we slowly more formally support v6. Most places (like the target hostnames) we dont care because it can be DNS as well - but if it is a actually IP then we probably should? LKM if you need help on this one and feel free to ping me or mark it as ready when you are good to go! |
|
@oschwartz10612 Very happy to support you! It's a heavy change so no stress on checking/merging. I think this will break all the current PRs. You are welcome to have already a look on it, but I did no testing in Prod system. That's the reason it is still in draft. |
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
In
server/lib/validators.tsz.cidr() and z.ip() musst be changed to z.cidrv4() and z.ipv4().Is there need for ipv6 validation?
-> added v6 support
Removed the "^" in package.json versions to avoid changes in packages-lock.json by accident when installing packages on a PR.
Migration guide
Codemod
Fixes #1514
Fixes #1513
Fixes #1277