-
-
Notifications
You must be signed in to change notification settings - Fork 465
Enhancement #906/Resources Dashboard: Targets Column, Customizable Columns & Status Indicators #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Enhancement #906/Resources Dashboard: Targets Column, Customizable Columns & Status Indicators #1328
Conversation
ad35114 to
a2e7b65
Compare
|
This is great! I think we want to take this one but I think we are not ready yet for the status reporting and checking and stuff - and this could conflict with the health checks we recently added to the cloud. Do you think you could remove the status online/offline column and the status indication for each of the targets? If so that would be great and then I think we could merge! I am sorry to ask you to remove work. I also think if we are going to do column filtering we should do it on all of the tables instead of just the resource table. And maybe we should move this button into the footer so it is not front in center for the user at the top? I think most of the time people will not want to change the columns but I think it is important that there is the ability. |
a2e7b65 to
38a0329
Compare
|
@oschwartz10612 , I’ve made the change. Could you please review and let me know if any further adjustments are needed? |
i do not think a status indicator would conflict with the cloud feature as you are just displaying if the backend is up or not. i also feels like gate-keeping when the code is there and functional, people using self-hosted do not deserve to have QOL feature kept away from them because it is somewhat similar to another service you sell. 😤 |
25b5bb0 to
5ef491b
Compare
896e3ca to
ceb2c23
Compare
|
Hey @Pallavikumarimdb! With the health checks out in oss we think we should complete this PR! Some notes we think we would like to change:
|
ceb2c23 to
0fb65b5
Compare
ac1739e to
9edd0b5
Compare
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
This PR implements the following enhancements to the Resources page, addressing issues #906 .
4.1 Show Target in the Dashboard
4.2 Customizable Columns
4.3 Status Icons
How to test?