Skip to content

Conversation

@Pallavikumarimdb
Copy link
Contributor

@Pallavikumarimdb Pallavikumarimdb commented Aug 24, 2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This PR implements the following enhancements to the Resources page, addressing issues #906 .

4.1 Show Target in the Dashboard

  • Added a new “Target” column to the Resources table.
  • Displays all configured targets for each resource in a dropdown menu.
  • Targets are copyable (ip:port) with a single click.
image

4.2 Customizable Columns

  • Introduced column toggle controls, allowing users to select which columns are visible.
  • Improves usability for large orgs with many resources.
image image

4.3 Status Icons

  • Added online/offline indicators (green/red dots):
  • Per resource: aggregated status → "online" if at least one target is reachable.
  • Per target: individual status displayed next to each target in the dropdown.
  • Status is determined via a lightweight TCP connectivity check (tcp-check-batch endpoint).
  • Results refresh on page reload; not intended as full monitoring, just quick QOL visibility.
image

How to test?

@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from ad35114 to a2e7b65 Compare August 24, 2025 16:04
@Pallavikumarimdb Pallavikumarimdb marked this pull request as ready for review August 25, 2025 05:03
@oschwartz10612
Copy link
Member

This is great! I think we want to take this one but I think we are not ready yet for the status reporting and checking and stuff - and this could conflict with the health checks we recently added to the cloud. Do you think you could remove the status online/offline column and the status indication for each of the targets? If so that would be great and then I think we could merge! I am sorry to ask you to remove work.

I also think if we are going to do column filtering we should do it on all of the tables instead of just the resource table. And maybe we should move this button into the footer so it is not front in center for the user at the top? I think most of the time people will not want to change the columns but I think it is important that there is the ability.

@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from a2e7b65 to 38a0329 Compare September 2, 2025 15:23
@Pallavikumarimdb
Copy link
Contributor Author

@oschwartz10612 , I’ve made the change. Could you please review and let me know if any further adjustments are needed?

@P6g9YHK6
Copy link

P6g9YHK6 commented Sep 3, 2025

This is great! I think we want to take this one but I think we are not ready yet for the status reporting and checking and stuff - and this could conflict with the health checks we recently added to the cloud. Do you think you could remove the status online/offline column and the status indication for each of the targets? If so that would be great and then I think we could merge! I am sorry to ask you to remove work.

I also think if we are going to do column filtering we should do it on all of the tables instead of just the resource table. And maybe we should move this button into the footer so it is not front in center for the user at the top? I think most of the time people will not want to change the columns but I think it is important that there is the ability.

i do not think a status indicator would conflict with the cloud feature as you are just displaying if the backend is up or not.
if not your failovers or any cloud feature would not work either.

i also feels like gate-keeping when the code is there and functional, people using self-hosted do not deserve to have QOL feature kept away from them because it is somewhat similar to another service you sell. 😤

@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from 25b5bb0 to 5ef491b Compare September 12, 2025 16:35
@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from 896e3ca to ceb2c23 Compare September 23, 2025 14:25
@oschwartz10612
Copy link
Member

Hey @Pallavikumarimdb! With the health checks out in oss we think we should complete this PR! Some notes we think we would like to change:

  • Combine the targets into the status column. Maybe when you hover/click on the status icon it shows the targets?
  • Use the health check status for the status of the target in the display
  • Targets can have unknown/not configured health checks. We should show these as gray icons
  • We should summarize the status icon with the info from the targets. So if all of the targets are green then the status is green, if some are red then it is a "degraded status" and the color is yellow or something with a different icon. If they are all red then the status should indicate that its fully offline. In the calculation maybe we omit the unknowns/no monitored targets.

@oschwartz10612 oschwartz10612 marked this pull request as draft October 8, 2025 20:58
@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from ceb2c23 to 0fb65b5 Compare October 20, 2025 16:15
@Pallavikumarimdb Pallavikumarimdb force-pushed the enhancement-#906/dashboard-enhancements branch from ac1739e to 9edd0b5 Compare October 30, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants