fix: memento format migration

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The migration script updates the way 'targetType' and 'targetId' fields are extracted from the logs.data JSON column for 'SET_METADATA' log types, switching from text extraction and casting to direct JSON extraction. The script also removes a trailing newline. No changes to exported or public entities were made.

Changes

File(s)	Change Summary
internal/storage/bucket/migrations/34-fix-memento-format/up.sql	Updated JSON extraction logic for 'targetType' and 'targetId' fields; removed trailing newline.

Sequence Diagram(s)

sequenceDiagram
    participant MigrationScript
    participant Database

    MigrationScript->>Database: For each 'SET_METADATA' log in logs
    Database-->>MigrationScript: Retrieve logs.data JSON
    MigrationScript->>MigrationScript: Extract targetType and targetId as JSON (using ->)
    MigrationScript->>Database: Update memento JSON with new extraction method

Loading

Possibly related PRs

• fix: memento format #926: Refines the JSON field extraction method for 'SET_METADATA' logs in the same migration script, indicating closely related code changes.

Suggested reviewers

• paul-nicolas

Poem

A hop, a skip, a JSON tweak,
Extraction changed—no cast this week!
Mementos fixed, the logs align,
The script now works just fine.
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fc3941 and 81e0691.

📒 Files selected for processing (1)

• internal/storage/bucket/migrations/34-fix-memento-format/up.sql (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Tests
• GitHub Check: Dirty

🔇 Additional comments (1)

internal/storage/bucket/migrations/34-fix-memento-format/up.sql (1)

52-53: Ensure downstream type compatibility when switching to JSON extraction
The change from ->> (text) plus casting to direct -> (JSON) correctly preserves the original JSON types. However, please verify that all downstream consumers of targetType and targetId expect JSON values (including potential null) rather than text or numeric types. If any downstream logic relies on text-based functions or comparisons, you may need to:

• Use ->> or explicit casts for those consumers, or
• Wrap with COALESCE(..., '<default>') to guard against null.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.