fix: performance compare #659
Conversation
WalkthroughThe pull request introduces a minor modification to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
test/performance/justfile (2)
20-20: LGTM! The-fflag addition improves error handling.The addition of the
-fflag tormis a good practice as it prevents the script from failing when the file doesn't exist.However, consider applying the same robustness improvement to other
rmcommands in the file.- rm -f {{output}} + rm -f {{output}} - trap 'rm -rf {{tmpdir}}' EXIT + trap 'rm -rf {{tmpdir}} 2>/dev/null' EXIT
20-23: Consider adding error handling for git operations.While the file removal is now more robust, the git clone operation could still fail due to network issues or repository access problems. Consider adding error handling for these operations.
rm -f ./report/benchmark-output-main.txt - git clone --depth 1 -b main https://github.com/formancehq/ledger {{tmpdir}} - cd {{tmpdir}}/test/performance && just run {{bench}} {{p}} {{benchtime}} {{count}} '../../../report/benchmark-output-main.txt' + if ! git clone --depth 1 -b main https://github.com/formancehq/ledger {{tmpdir}}; then + echo "Failed to clone repository" + exit 1 + fi + if ! cd {{tmpdir}}/test/performance && just run {{bench}} {{p}} {{benchtime}} {{count}} '../../../report/benchmark-output-main.txt'; then + echo "Failed to run benchmark on main branch" + exit 1 + fi
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
- Coverage 81.68% 81.55% -0.13%
==========================================
Files 131 131
Lines 7059 7059
==========================================
- Hits 5766 5757 -9
- Misses 992 998 +6
- Partials 301 304 +3 ☔ View full report in Codecov by Sentry. |
No description provided.