fix: add validation for malformed headers in metrics module and add unit tests #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…s to the OTEL config
…nit tests Co-Authored-By: maxence@formance.com <maxence@formance.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: maxence@formance.com <maxence@formance.com>
|
@coderabbitai review |
paul-nicolas
approved these changes
Apr 7, 2025
gfyrag
reviewed
Apr 7, 2025
| headersMap := make(map[string]string) | ||
| for _, header := range otelMetricsExporterOTLPHeaders { | ||
| parts := strings.SplitN(header, "=", 2) | ||
| if len(parts) == 2 { |
There was a problem hiding this comment.
Handle the case where len(parts) == 1
Co-Authored-By: maxence@formance.com <maxence@formance.com>
gfyrag
reviewed
Apr 7, 2025
otlp/otlpmetrics/cli.go
Outdated
| if len(parts) == 2 { | ||
| headersMap[parts[0]] = parts[1] | ||
| } else if len(parts) == 1 { | ||
| continue |
Co-Authored-By: maxence@formance.com <maxence@formance.com>
gfyrag
reviewed
Apr 7, 2025
otlp/otlpmetrics/cli.go
Outdated
| if len(parts) == 2 { | ||
| headersMap[parts[0]] = parts[1] | ||
| } else if len(parts) == 1 && parts[0] != "" { | ||
| panic("malformed header: " + header + " (missing value)") |
There was a problem hiding this comment.
Damn, just return a CLI error
Co-Authored-By: maxence@formance.com <maxence@formance.com>
gfyrag
reviewed
Apr 7, 2025
otlp/otlpmetrics/cli.go
Outdated
| if len(parts) == 2 { | ||
| headersMap[parts[0]] = parts[1] | ||
| } else if len(parts) == 1 && parts[0] != "" { | ||
| cmd.PrintErrf("Error: malformed header: %s (missing value)\n", header) |
Co-Authored-By: maxence@formance.com <maxence@formance.com>
laouji
reviewed
Apr 7, 2025
Co-Authored-By: maxence@formance.com <maxence@formance.com>
laouji
approved these changes
Apr 7, 2025
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues identified in PR #333:
Link to Devin run: https://app.devin.ai/sessions/3d6fd518f5a5497cb18d40cbfdb321e6
Requested by: maxence@formance.com