Link file for air
#728
Closed
Link file for air
#728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InfiniteEchoes
commented
May 14, 2025
Comment on lines
21
to
26
| (* NOTE: It looks like Coq will take infinitely long time to find an | ||
| appropriate class for this instance *) | ||
| Global Instance IsLink (T V : Set) : Link (t T V) := { | ||
| Φ := Ty.apply (Ty.path "plonky3::matrix::dense::DenseMatrix") [ φ T; φ V ] []; | ||
| φ := to_value; | ||
| }. |
There was a problem hiding this comment.
Coq cannot find correct class for this instance.
There was a problem hiding this comment.
OK yes in some cases Rocq prefers to make an infinite loop instead of showing a clean error message.
Maybe you can specify the type parameters of to_value? With to_value (T := T) (V := V) for example?
There was a problem hiding this comment.
According to https://github.com/formal-land/coq-of-rust/blob/main/CoqOfRust/lib/lib.v#L33 it should be:
Suggested change
| (* NOTE: It looks like Coq will take infinitely long time to find an | |
| appropriate class for this instance *) | |
| Global Instance IsLink (T V : Set) : Link (t T V) := { | |
| Φ := Ty.apply (Ty.path "plonky3::matrix::dense::DenseMatrix") [ φ T; φ V ] []; | |
| φ := to_value; | |
| }. | |
| (* NOTE: It looks like Coq will take infinitely long time to find an | |
| appropriate class for this instance *) | |
| Global Instance IsLink (T V : Set) : Link (t T V) := { | |
| Φ := Ty.apply (Ty.path "plonky3::matrix::dense::DenseMatrix") [ ] [ φ T; φ V ]; | |
| φ := to_value; | |
| }. |
|
A squashed version is available there: #736 I am merging it once it is green! |
|
Closed and being continued in #737 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Plonky3into repositoryairfile, with its dependencies sufficiently explored. Future task onairlink can be safely cut into smaller tasks