Skip to content

fix(util): use vim.ui.open to open uri #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(util): use vim.ui.open to open uri #1948

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c546b12
fix: use vim.ui.open to open uri
80avin Mar 13, 2025
d1f6c3c
Update util.lua
80avin Mar 14, 2025
5f10bb0
Update util.lua
80avin Mar 14, 2025
f6090f6
Update util.lua
80avin Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 37 additions & 23 deletions lua/lazy/util.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,33 +25,47 @@ function M.open(uri, opts)
if not opts.system and M.file_exists(uri) then
return M.float({ style = "", file = uri })
end
local Config = require("lazy.core.config")
local cmd
if not opts.system and Config.options.ui.browser then
cmd = { Config.options.ui.browser, uri }
elseif vim.fn.has("win32") == 1 then
cmd = { "explorer", uri }
elseif vim.fn.has("macunix") == 1 then
cmd = { "open", uri }
if vim.fn.has('nvim-0.10.0') then
local ret = vim.fn.jobstart(cmd, { detach = true })
if ret <= 0 then
local msg = {
"Failed to open uri",
ret,
vim.inspect(cmd),
}
local cmd, err = vim.ui.open(uri)
if cmd then
cmd:wait()
end
if err then
local msg = {
"Failed to open uri",
err,
vim.inspect(uri),
}
vim.notify(table.concat(msg, "\n"), vim.log.levels.ERROR)
end
else
if vim.fn.executable("xdg-open") == 1 then
cmd = { "xdg-open", uri }
elseif vim.fn.executable("wslview") == 1 then
cmd = { "wslview", uri }
else
local Config = require("lazy.core.config")
local cmd
if not opts.system and Config.options.ui.browser then
cmd = { Config.options.ui.browser, uri }
elseif vim.fn.has("win32") == 1 then
cmd = { "explorer", uri }
elseif vim.fn.has("macunix") == 1 then
cmd = { "open", uri }
else
if vim.fn.executable("xdg-open") == 1 then
cmd = { "xdg-open", uri }
elseif vim.fn.executable("wslview") == 1 then
cmd = { "wslview", uri }
elseif vim.fn.executable("explorer.exe") == 1 then
cmd = { "explorer.exe", uri }
else
cmd = { "open", uri }
end
end
end

local ret = vim.fn.jobstart(cmd, { detach = true })
if ret <= 0 then
local msg = {
"Failed to open uri",
ret,
vim.inspect(cmd),
}
vim.notify(table.concat(msg, "\n"), vim.log.levels.ERROR)
end
end

function M.read_file(file)
Expand Down