Skip to content

Re-align log-levels with logrus #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2025
Merged

Re-align log-levels with logrus #435

merged 1 commit into from
Feb 9, 2025

Conversation

folbricht
Copy link
Owner

#422 switched from logrus to slog. It slightly changed the meaning of log-levels which caused #433

@folbricht folbricht merged commit 67589fd into master Feb 9, 2025
3 checks passed
@folbricht folbricht deleted the issue-433 branch February 9, 2025 13:21
@folbricht folbricht mentioned this pull request Feb 9, 2025
Closed
@Anuskuss
Copy link
Contributor

Anuskuss commented Feb 9, 2025

IMO 0 should be disabled and 1 should be Error. Also don't forget to update

routedns/cmd/routedns/main.go

Line 57 in 383193d

cmd.Flags().Uint32VarP(&opt.logLevel, "log-level", "l", 4, "log level; 0=None .. 6=Trace")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@folbricht @Anuskuss