Add support for 0rtt connection resumption to DoH and DoQ listeners. #414
Conversation
doqlistener.go
Outdated
| if err := binary.Read(stream, binary.BigEndian, &length); err != nil { | ||
| s.metrics.err.Add("read", 1) | ||
| log.WithError(err).Error("failed to read query") | ||
| CloseConn(connection, log) |
There was a problem hiding this comment.
Not a fan of closing the connection in multiple places, including from within the stream. One effect of doing it here will be that connection.AcceptStream(ctx) above will return an error, which will then call CloseConn a second time. It should write "closing connection" twice in the logs too.
The prior implementation only closed it in one place. Is that not working? If a stream fails, I'd expect AcceptStream() to also fail, which then closes the connection.
There was a problem hiding this comment.
I agree. I did remove the changes and updated the PR
|
There is currently still a problem when the server restarts and the client still holds an old session ticket. I think the client should automatically retry without the session ticket after it failed to (re)open the connection. Will work on this now |
2 participants
Add support for 0rtt connection resumption to DoH and DoQ listeners.