-
Notifications
You must be signed in to change notification settings - Fork 39
Databricks Support #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for porting this change to this repository.
I have left a couple of review comments to do before merging.
If you have any documentation you could point us to to allow us to smoke test this integration, that would be appreciated.
...abase-databricks/src/main/resources/META-INF/services/org.flywaydb.core.extensibility.Plugin
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comment was meant to be a change request.
Can this be merged in now? @Barry-RG |
cc: @tdimhcsleumas @skitscha |
I should be able to help test this integration but the build is failing and I cannot contribute to this branch to fix it. @tdimhcsleumas Can you resolve the build issue? |
@skitscha1 yes. I'll set aside some time in the next few days to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a look and here are changes that needed to be made to get this building
...se-databricks/src/main/java/org/flywaydb/community/database/DatabricksDatabaseExtension.java
Outdated
Show resolved
Hide resolved
...ase-databricks/src/main/java/org/flywaydb/community/database/databricks/DatabricksTable.java
Outdated
Show resolved
Hide resolved
...-databricks/src/main/java/org/flywaydb/community/database/databricks/DatabricksDatabase.java
Outdated
Show resolved
Hide resolved
...-databricks/src/main/java/org/flywaydb/community/database/databricks/DatabricksDatabase.java
Outdated
Show resolved
Hide resolved
...abricks/src/main/java/org/flywaydb/community/database/databricks/DatabricksDatabaseType.java
Outdated
Show resolved
Hide resolved
Thanks @piers-williams, I'll implement those changes shortly. |
This change ports this pr: flyway/flyway#3681