Skip to content

Databricks Support #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 8, 2024
Merged

Databricks Support #26

merged 13 commits into from
May 8, 2024

Conversation

tdimhcsleumas
Copy link
Contributor

This change ports this pr: flyway/flyway#3681

@tdimhcsleumas tdimhcsleumas marked this pull request as ready for review February 21, 2024 07:42
@tdimhcsleumas tdimhcsleumas reopened this Feb 21, 2024
Copy link
Contributor

@Barry-RG Barry-RG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for porting this change to this repository.
I have left a couple of review comments to do before merging.

If you have any documentation you could point us to to allow us to smoke test this integration, that would be appreciated.

Copy link
Contributor

@Barry-RG Barry-RG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment was meant to be a change request.

@skitscha
Copy link

skitscha commented Apr 26, 2024

Can this be merged in now? @Barry-RG

@Barry-RG Barry-RG closed this Apr 30, 2024
@Barry-RG Barry-RG reopened this Apr 30, 2024
@Barry-RG
Copy link
Contributor

cc: @tdimhcsleumas @skitscha
We are currently in the process of trying to test this integration with Databricks and Flyway.
If you have any tests or test cases that could help expedite this PR

@skitscha1
Copy link

I should be able to help test this integration but the build is failing and I cannot contribute to this branch to fix it. @tdimhcsleumas Can you resolve the build issue?

@tdimhcsleumas
Copy link
Contributor Author

@skitscha1 yes. I'll set aside some time in the next few days to fix it.

Copy link
Contributor

@piers-williams piers-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken a look and here are changes that needed to be made to get this building

@tdimhcsleumas
Copy link
Contributor Author

Thanks @piers-williams, I'll implement those changes shortly.

@tdimhcsleumas
Copy link
Contributor Author

@skitscha @Barry-RG I ran mvn -B install --file pom.xml locally and got a successful build.

@piers-williams piers-williams merged commit 7d40760 into flyway:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants