Resolve issue where 'subtitleOn' doesn't enable subtitles by default on iOS #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
lib/src/cupertino/cupertino_controls.dart
file. It updates the_initialize
method to correctly assign the_subtitleOn
flag based onchewieController.showSubtitles
and whether thesubtitle
is not empty.Previously, the code was:
This line had no effects and was effectively dead code. The condition was evaluated but not used.
The updated version assigns the result of the condition to
_subtitleOn
:This change ensures that subtitles are properly enabled by default when the
showSubtitles
flag is true and a non-empty subtitle is present.File Changes
[lib/src/cupertino/cupertino_controls.dart](https://www.notion.so/1cfd8b130ac680f381d4c435719819ff?pvs=21)
: Updated_initialize
method to assign_subtitleOn
.