-
Notifications
You must be signed in to change notification settings - Fork 9
Upgrade iOS SDK to v200.7 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JulianBissekkou
merged 10 commits into
migrate-ios-to-swift-package-manager
from
upgrade-arcgis-sdk
May 6, 2025
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
99b27d8
Upgrade arcgis sdk
TarekTolba1 b74ff0b
Upgrade arcgis sdk + create MapContentView
TarekTolba1 197e084
Fix few issues after upgrading sdk
TarekTolba1 a5a2a1f
Fix few issues after upgrading sdk
TarekTolba1 1aca0d9
Merge branch 'migrate-ios-to-swift-package-manager' into upgrade-arcg…
TarekTolba1 8734463
Clean code
TarekTolba1 8762e6f
fix build
JulianBissekkou e383c99
reformat code
JulianBissekkou 40f5cef
Update CustomLocationProvider.swift
TarekTolba1 1448144
Fix location indicator example
TarekTolba1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
387 changes: 184 additions & 203 deletions
387
arcgis_map_sdk_ios/ios/arcgis_map_sdk_ios/Sources/arcgis_map_sdk_ios/ArcgisMapView.swift
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
arcgis_map_sdk_ios/ios/arcgis_map_sdk_ios/Sources/arcgis_map_sdk_ios/MapContentView.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
// | ||
// Created by Tarek Tolba on 29/04/2025. | ||
// | ||
|
||
import SwiftUI | ||
import ArcGIS | ||
import CoreLocation | ||
|
||
|
||
struct MapContentView: View { | ||
@ObservedObject var viewModel: MapViewModel | ||
|
||
init(viewModel: MapViewModel) { | ||
self.viewModel = viewModel | ||
} | ||
|
||
var body: some View { | ||
MapViewReader { mapViewProxy in | ||
MapView( | ||
map: viewModel.map, | ||
viewpoint: viewModel.viewpoint, | ||
graphicsOverlays: [viewModel.defaultGraphicsOverlay] | ||
) | ||
.attributionBarHidden(viewModel.attributionBarHidden) | ||
.locationDisplay(viewModel.locationDisplay) | ||
.contentInsets(viewModel.contentInsets) | ||
.interactionModes(viewModel.interactionModes) | ||
.onViewpointChanged(kind: .centerAndScale) { newViewpoint in | ||
viewModel.viewpoint = newViewpoint | ||
} | ||
.onScaleChanged { scale in | ||
viewModel.onScaleChanged?(scale) | ||
} | ||
.onVisibleAreaChanged { polygon in | ||
viewModel.onVisibleAreaChanged?(polygon) | ||
} | ||
.onChange(of: viewModel.map.basemap?.loadStatus) { newValue in | ||
if let newValue { | ||
viewModel.onLoadStatusChanged?(newValue) | ||
} | ||
} | ||
.task { | ||
// Store the mapViewProxy for external access | ||
viewModel.mapViewProxy = mapViewProxy | ||
} | ||
.onDisappear { | ||
viewModel.stopLocationDataSource() | ||
// Clear the mapViewProxy reference when view disappears | ||
viewModel.mapViewProxy = nil | ||
} | ||
.ignoresSafeArea(edges: .all) | ||
} | ||
} | ||
} | ||
|
||
|
||
class MapViewModel: ObservableObject { | ||
let map = Map() | ||
let locationDisplay = LocationDisplay() | ||
|
||
@Published var viewpoint: Viewpoint | ||
@Published var mapViewProxy: MapViewProxy? | ||
@Published var attributionBarHidden: Bool = false | ||
@Published var contentInsets: EdgeInsets = EdgeInsets() | ||
@Published var interactionModes: MapViewInteractionModes = .all | ||
@Published var defaultGraphicsOverlay = GraphicsOverlay() | ||
|
||
var onScaleChanged: ((Double) -> Void)? | ||
var onVisibleAreaChanged: ((Polygon) -> Void)? | ||
var onLoadStatusChanged: ((LoadStatus) -> Void)? | ||
|
||
init(viewpoint : Viewpoint) { | ||
self.viewpoint = viewpoint | ||
} | ||
|
||
/// Stops the location data source. | ||
func stopLocationDataSource() { | ||
Task { | ||
await locationDisplay.dataSource.stop() | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the file name to be
CustomLocationProvider.swift
?