[Product Quality] Fix copy-to-clipboard behavior in the console #9204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? instanceRef.valueAsString | ||
| : instanceRef; | ||
| return '$name - $value'; | ||
| if (instanceRef != null && (name ?? '').isNotEmpty) { |
There was a problem hiding this comment.
use !name.isNullOrEmpty here instead
| // Inspector nodes. | ||
| final diagnostic = ref?.diagnostic; | ||
| final description = diagnostic?.description; | ||
| if (diagnostic != null && description != null) { |
There was a problem hiding this comment.
nit: the diagnostic != null check is redundant here
kenzieschmoll
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4915
Work towards #8939
Previously, copying an inspected widget from the console would copy
null. Now, the name and text preview (if it exists) will be copied.Also improves what is copied for any instance variables that have a
length(maps, lists, sets, etc). The test cases indart_object_node_test.dartshow what is copied in each case.