Skip to content

Fix class filter. #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class ClassFilter {

// Return previous data if filter is identical.
final task = newFilter.task(previous: oldFilter);
if (task == FilteringTask.doNothing) return original;
if (task == FilteringTask.doNothing) return oldFiltered!;

final Iterable<T> dataToFilter;
if (task == FilteringTask.refilter) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,39 @@ void main() {
expect(filter.filters, {'f1', 'f2', 'f3'});
});

test('$ClassFilter.filter filters.', () {
final filter = ClassFilter(
test('$ClassFilter.filter is noop when not selected filter changes.', () {
final filter1 = ClassFilter(
filterType: ClassFilterType.except,
except: 'class1, library2, library3/class3',
only: '',
);

final result = ClassFilter.filter(
final result1 = ClassFilter.filter(
oldFilter: null,
newFilter: filter,
newFilter: filter1,
oldFiltered: null,
original: _data,
extractClass: (c) => c,
rootPackage: null,
);

expect(result, [_class4]);
expect(result1, [_class4]);

final filter2 = ClassFilter(
filterType: ClassFilterType.except,
except: filter1.except,
only: 'something',
);

final result2 = ClassFilter.filter(
oldFilter: filter1,
newFilter: filter2,
oldFiltered: result1,
original: _data,
extractClass: (c) => c,
rootPackage: null,
);

expect(result2, result1);
});
}
Loading