Skip to content

Commit 24f43f1

Browse files
authored
[Property Editor] Include error code in exceptions sent to GA (#9209)
1 parent ecec166 commit 24f43f1

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,7 @@ mixin _PropertyInputMixin<T extends StatefulWidget, U> on State<T> {
386386
final succeeded = errorResponse == null || errorResponse.success;
387387
if (!succeeded) {
388388
setState(() {
389-
_serverError =
390-
'${errorResponse.errorType?.message ?? 'Encountered unknown error.'} (Property: ${property.name})';
389+
_serverError = _errorMessage(errorResponse, property: property);
391390
});
392391
ga.reportError('property-editor $_serverError');
393392
}
@@ -400,4 +399,20 @@ mixin _PropertyInputMixin<T extends StatefulWidget, U> on State<T> {
400399
),
401400
);
402401
}
402+
403+
String _errorMessage(
404+
EditArgumentResponse errorResponse, {
405+
required EditableProperty property,
406+
}) {
407+
final errorType = errorResponse.errorType;
408+
final messageFromType = errorType?.message;
409+
final messageFromResponse = errorResponse.errorMessage;
410+
final errorMessage =
411+
(messageFromType != null && messageFromResponse != null)
412+
? '$messageFromType / $messageFromResponse'
413+
: messageFromType ?? messageFromResponse ?? 'Unknown error.';
414+
final propertyInfo = '(Property: ${property.name})';
415+
final errorCode = errorType?.code != null ? '${errorType!.code}: ' : '';
416+
return '$errorCode$errorMessage $propertyInfo';
417+
}
403418
}

0 commit comments

Comments
 (0)