Skip to content

Commit ecec166

Browse files
authored
[Widget Inspector] Update Select Widget Mode icon (#9192)
1 parent 69090a0 commit ecec166

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

packages/devtools_app/lib/src/service/service_extensions.dart

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
44

55
import 'package:devtools_app_shared/service_extensions.dart' as extensions;
6-
import 'package:flutter/cupertino.dart' show CupertinoIcons;
76
import 'package:flutter/material.dart';
87

98
import '../shared/analytics/constants.dart' as gac;
@@ -436,6 +435,13 @@ final httpEnableTimelineLogging =
436435
tooltip: 'Toggle HTTP timeline logging',
437436
);
438437

438+
/// The icon used for all "Select widget mode" buttons, both in DevTools and in
439+
/// the Flutter framework.
440+
///
441+
/// This is a generic unicode icon which lets us have one consistent icon across
442+
/// Material and Cupertino-styled apps.
443+
const selectWidgetModeIcon = IconData(0x1F74A);
444+
439445
// Legacy extension to show the inspector and enable inspector select mode.
440446
final toggleOnDeviceWidgetInspector =
441447
ToggleableServiceExtensionDescription<bool>.from(
@@ -445,7 +451,7 @@ final toggleOnDeviceWidgetInspector =
445451
// toggling widget select mode as it is the only way to toggle that mode.
446452
title: 'Select Widget Mode',
447453
shortTitle: 'Select',
448-
iconData: CupertinoIcons.cursor_rays,
454+
iconData: selectWidgetModeIcon,
449455
gaScreenName: gac.inspector,
450456
gaItem: gac.showOnDeviceInspector,
451457
tooltip: 'Toggle select widget mode',
@@ -459,7 +465,7 @@ final toggleOnDeviceWidgetInspector =
459465
final toggleSelectWidgetMode = ToggleableServiceExtensionDescription<bool>.from(
460466
extensions.toggleSelectWidgetMode,
461467
title: 'Select widget mode',
462-
iconData: CupertinoIcons.cursor_rays,
468+
iconData: selectWidgetModeIcon,
463469
gaScreenName: gac.inspector,
464470
gaItem: gac.selectWidgetMode,
465471
tooltip: 'Toggle select widget mode',

packages/devtools_app/macos/Runner.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@
553553
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
554554
GCC_WARN_UNUSED_FUNCTION = YES;
555555
GCC_WARN_UNUSED_VARIABLE = YES;
556-
MACOSX_DEPLOYMENT_TARGET = 10.14;
556+
MACOSX_DEPLOYMENT_TARGET = 10.15;
557557
MTL_ENABLE_DEBUG_INFO = NO;
558558
SDKROOT = macosx;
559559
SWIFT_COMPILATION_MODE = wholemodule;
@@ -632,7 +632,7 @@
632632
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
633633
GCC_WARN_UNUSED_FUNCTION = YES;
634634
GCC_WARN_UNUSED_VARIABLE = YES;
635-
MACOSX_DEPLOYMENT_TARGET = 10.14;
635+
MACOSX_DEPLOYMENT_TARGET = 10.15;
636636
MTL_ENABLE_DEBUG_INFO = YES;
637637
ONLY_ACTIVE_ARCH = YES;
638638
SDKROOT = macosx;
@@ -679,7 +679,7 @@
679679
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
680680
GCC_WARN_UNUSED_FUNCTION = YES;
681681
GCC_WARN_UNUSED_VARIABLE = YES;
682-
MACOSX_DEPLOYMENT_TARGET = 10.14;
682+
MACOSX_DEPLOYMENT_TARGET = 10.15;
683683
MTL_ENABLE_DEBUG_INFO = NO;
684684
SDKROOT = macosx;
685685
SWIFT_COMPILATION_MODE = wholemodule;

packages/devtools_app/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ resolution: workspace
2020
dependencies:
2121
async: ^2.0.0
2222
collection: ^1.15.0
23-
cupertino_icons: ^1.0.0
2423
dap: ^1.1.0
2524
dds_service_extensions: ^2.0.0
2625
devtools_app_shared:

0 commit comments

Comments
 (0)