Skip to content

Properly enable intro_flutter_gpu on master #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flutter_ci_script_shared.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ function ci_codelabs () {

# intro_flutter_gpu only runs with Impeller
if [ $CODELAB = 'intro_flutter_gpu' ]; then
# Skipping Windows: https://github.com/bdero/flutter_scene/issues/55
if [ $RUNNER_OS = 'macOS' ] || [ $RUNNER_OS = 'Linux' ]; then
# Skipping Windows and Linux: https://github.com/bdero/flutter_scene/issues/55
if [ $RUNNER_OS = 'macOS' ]; then
flutter config --enable-native-assets
flutter build `echo $RUNNER_OS | tr '[:upper:]' '[:lower:]'` --debug
flutter test --enable-impeller
flutter test --enable-flutter-gpu
else
echo "Skipping $CODELAB on $RUNNER_OS"
fi
Expand Down
4 changes: 2 additions & 2 deletions intro_flutter_gpu/codelab_rebuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ steps:
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true);
});
}
- name: Patch macos/Runner/Info.plist
path: intro_flutter_gpu/macos/Runner/Info.plist
Expand Down Expand Up @@ -2218,7 +2218,7 @@ steps:
+ await tester.pumpWidget(
+ MainApp(staticResourcesInitialized: Scene.initializeStaticResources()),
+ );
}, skip: true);
});
}
- name: Copy step_12
copydir:
Expand Down
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_01/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_02/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_03/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_04/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_05/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_06/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_07/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_08/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_09/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_10/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_11/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ void main() {
testWidgets('smoke test', (tester) async {
// Build our app and trigger a frame.
await tester.pumpWidget(const MainApp());
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
2 changes: 1 addition & 1 deletion intro_flutter_gpu/step_12/test/widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ void main() {
await tester.pumpWidget(
MainApp(staticResourcesInitialized: Scene.initializeStaticResources()),
);
}, skip: true); // See https://github.com/flutter/flutter/issues/171361
});
}
Loading