Skip to content

Feat: Add patchError function to FormBuilder #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GChanathip
Copy link

@GChanathip GChanathip commented Apr 6, 2025

Connection with issue(s)

Close #???

Connected to #???

Solution description

This method help us to add errors to fields at once.
This is useful if form need to validate by server.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@GChanathip
Copy link
Author

GChanathip commented Apr 6, 2025

not sure if everyone like this behavior.
if yes, i will write tests to cover this function.

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (fffb27d) to head (2d6fe1e).

Files with missing lines Patch % Lines
lib/src/form_builder.dart 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
- Coverage   89.88%   89.47%   -0.41%     
==========================================
  Files          21       21              
  Lines         840      846       +6     
==========================================
+ Hits          755      757       +2     
- Misses         85       89       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deandreamatias
Copy link
Collaborator

deandreamatias commented Apr 17, 2025

Hi!
This is interesting, but I need evaluate how can integrate with existent API and with future features (like #1485).

Also, need to align with discussion #1466 and with maintenance philosophy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants