-
Notifications
You must be signed in to change notification settings - Fork 34
Add buffer_limit_size and buffer_overflow_method #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any updates for this feature? |
@okkez Would it be possible to merge and release this feature? This is useful to us to avoid event too large errors when flushing to CloudWatch. |
@kenhys Can you take a look? |
Hello, it would be nice to have this feature released. Basicly we use concat plugin to concatenate containerd logs with partial_key/partial_value but what happens sometimes we may get very large logs which can trigger BufferChunkOverflowError error and lead to OOM/crash of fluentd. @okkez do you happen to know any workaround for now? to avoid large log lines hit fluentd output plugin/buffer so we avoid BufferChunkOverflowError |
@okkez Can you please fix the conflict? |
I will try. |
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
1021e19
to
fef55ac
Compare
I solved the confilict and fixed up the commits. |
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Thanks @Watson1978! |
Adds a size limit for concatenation.
If a concatenated record will overflow, the concatenate behavior will follow the `buffer_overflow_method'.
By default, it will continue to behave as before.