Skip to content

Add buffer_limit_size and buffer_overflow_method #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

okkez
Copy link
Member

@okkez okkez commented Mar 18, 2019

Adds a size limit for concatenation.
If a concatenated record will overflow, the concatenate behavior will follow the `buffer_overflow_method'.

By default, it will continue to behave as before.

@cristianpetrula
Copy link

Any updates for this feature?

@emil2k
Copy link

emil2k commented Jun 7, 2023

@okkez Would it be possible to merge and release this feature? This is useful to us to avoid event too large errors when flushing to CloudWatch.

@okkez
Copy link
Member Author

okkez commented Jun 8, 2023

@kenhys Can you take a look?

@ashie ashie self-assigned this Jun 8, 2023
@whitepiratebaku
Copy link

Hello, it would be nice to have this feature released. Basicly we use concat plugin to concatenate containerd logs with partial_key/partial_value but what happens sometimes we may get very large logs which can trigger BufferChunkOverflowError error and lead to OOM/crash of fluentd. @okkez do you happen to know any workaround for now? to avoid large log lines hit fluentd output plugin/buffer so we avoid BufferChunkOverflowError

@daipom daipom assigned daipom and unassigned ashie Apr 16, 2025
@daipom daipom moved this to To-Do in Fluentd Kanban Apr 16, 2025
@Watson1978 Watson1978 self-requested a review May 7, 2025 02:56
@Watson1978
Copy link
Contributor

@okkez Can you please fix the conflict?

@daipom
Copy link
Contributor

daipom commented May 7, 2025

I will try.

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
@Watson1978 Watson1978 force-pushed the buffer_size_limit branch from 1021e19 to fef55ac Compare May 8, 2025 06:49
@Watson1978
Copy link
Contributor

Watson1978 commented May 8, 2025

I solved the confilict and fixed up the commits.
And I backed up the original PR in Watson1978#1

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Watson1978 Watson1978 merged commit 5a6932f into master Jun 12, 2025
24 checks passed
@Watson1978 Watson1978 deleted the buffer_size_limit branch June 12, 2025 01:57
@daipom
Copy link
Contributor

daipom commented Jun 12, 2025

Thanks @Watson1978!

@daipom daipom changed the title Add buffer_size_limit and buffer_overflow_method Add buffer_limit_size and buffer_overflow_method Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants