Skip to content

WIP: API and CLI for render graph image #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 3, 2018
Merged

WIP: API and CLI for render graph image #374

merged 20 commits into from
Jan 3, 2018

Conversation

jonnor
Copy link
Member

@jonnor jonnor commented Jan 1, 2018 •
edited
Loading

So one can output a PNG/JPEG (and SVG). Useful for instance in documentation

Missing

  • Rendering element to canvas and saving as PNG
  • CLI tool that can run this in browser and return results
  • Fit viewport to the graph
  • Fix hosting hosting of jsjob script in CLI tool. Alt: Allow hosting job scripts jsjob#41
  • Move API code into library, only .jsjob outside
  • Tests

Future

  • Fix group labels show fully opaque/white
  • Fix missing FontAwesome icons (components, exported ports)
  • Perform autolayout when neccesary (graph w/o position info)
  • Allow enforcing high level-of-detail (always portnames, component names)

Closes #287

jonnor added 20 commits January 1, 2018 18:45
@jonnor
Don't use theme for basic positioning
58adf29
@jonnor
Sketches for rending picture
4fe5a49
@jonnor
Can render basic image of graph
57d7bc5
@jonnor
set canvas width
29582e7
@jonnor
code for rendering graph programatically
ef99aab
@jonnor
Can render with clean DOM
6a05efd 
Needs bundling into one package now
@jonnor
bundle JS using browserify
8163d47
@jonnor
Can run as JsJob
b14ce99 
Though styling is not applied there, it seems
@jonnor
fix style loading in phantomjs
df0c02b
@jonnor
Fix background in rendered image
13cd108
@jonnor
render incoming graph JSON
9d35d50
@jonnor
the-graph-render: Dedicated CLI tool
63840dd
@jonnor
Allow specifying couple more things
e63ca13
@jonnor
render: Fix passing SVG output
d139930
@jonnor
render: Calculate height automatically to fit
0ecbeff
@jonnor
render: Fix format option (rendering JPEG), add quality
cb8c4d2
@jonnor
the-graph-render: Host job script
2cd8c44
@jonnor
Move render functionality into module
77e646b
@jonnor
render: Synthesise component ports from exports
c00259c 
Also fix duplicated ports
@jonnor
tests: Add basic tests for the-graph-render (node.js)
9cbd480
@jonnor jonnor merged commit 9cbd480 into master Jan 3, 2018
@jonnor
Copy link
Member Author

jonnor commented Jan 3, 2018

Grr, accidentially pushed to master

@jonnor jonnor mentioned this pull request Jan 3, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonnor