Skip to content

Allow to render to SVG/image #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonnor opened this issue Jul 9, 2016 · 4 comments
Closed

Allow to render to SVG/image #287

jonnor opened this issue Jul 9, 2016 · 4 comments

Comments

@jonnor
Copy link
Member

jonnor commented Jul 9, 2016

For getting a snapshot of a graph, and maybe sharing it outside the app that uses the-graph.
Could be used as basis for simple visual diffing tools for FBP graphs.

@jonnor
Copy link
Member Author

jonnor commented Jul 9, 2016

I had hoped we could just use DOM-level rendering for this. I did a test with dom-to-image, which was not successful: fails with some unspecified image error event when used on the-graph-editor. However, it worked fine for some <textarea> elements etc. https://github.com/flowbased/flowtrace/commits/visualdiff

Still to be tested are some of the SVG-aware DOM node rendering methods.

@forresto
Copy link
Collaborator

To start, do we want to viz JSON or FBP diffs? Both? If FBP I guess we need the autolayout step.

Have you tried to mount the-graph in Phantom to get a PNG?

Github doesn't support SVG upload, so even if we can output the SVG string diffbot will need to convert it.

@jonnor
Copy link
Member Author

jonnor commented Jul 13, 2016

Both ideally. We should probably run autolayout if explicit position information on nodes (x,y) is missing.

@jonnor
Copy link
Member Author

jonnor commented Jan 3, 2018

Not merged yet

@jonnor jonnor reopened this Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants