Skip to content

Conversation

@JustCryen
Copy link
Contributor

As discussed in #1751
I'm open to suggestions about description phrasing in the README

@JustCryen
Copy link
Contributor Author

@ChrisLane @flightlessmango
It's been a while, I'm not sure if you have seen this PR.
It is linked to the previous one but maybe you haven't got a notification for it.

Copy link

@ChrisLane ChrisLane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't seen this but the changes look sensible.

A couple of minor points to consider for potential improvements:

  1. FPS superscript still appears for FPS stats in the fps_metrics component.
  2. hide_engine_names does not override engine_short_names so if the latter appears in config, the former will not take effect.

@JustCryen
Copy link
Contributor Author

I have noticed the second behavior but I wasn't sure how this should be handled.
This being said, I will correct this shortly.

@flightlessmango
Copy link
Owner

hide_engine_names does not override engine_short_names so if the latter appears in config, the former will not take effect.

This has been reworked a bit in e96a0bf
Might have accidentally fixed it?

@ChrisLane
Copy link

ChrisLane commented Oct 27, 2025

hide_engine_names does not override engine_short_names so if the latter appears in config, the former will not take effect.

This has been reworked a bit in e96a0bf Might have accidentally fixed it?

Still reproducible as of mangohud-git @ 5399bf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants