Fix(1784): no_small_font not working as intended #1785
Conversation
jbellionjourdan
force-pushed
the
fix/no_small_font
branch
from
4bb6a62 to
4dfc4e2
Compare
| ImguiNextColumnOrNewRow(); | ||
|
|
||
| HUDElements.TextColored(HUDElements.colors.text, "%s\n", HUDElements.get_present_mode().c_str()); | ||
| right_aligned_text(HUDElements.colors.text, HUDElements.ralign_width * 1.5f, "%s\n", HUDElements.get_present_mode().c_str()); |
There was a problem hiding this comment.
Even tho in most places 1.3 is used instead of 1.5, it will line up?
Maybe it should be 1.5 in every place? making a descriptive variable for it might also be good
There was a problem hiding this comment.
I didn't see many other occurrences of the 1.3, i think there were 2 of them in some complex metric (maybe related to gamescope but unsure).
I didn't know how to test this one so i'd rather have a slight misalignment than risking to break something on that.
Honestly this number is totally empiric, there was already some misalignment with other metrics before, i fiddled a bit with the value to see what impact it'd have, and 1.5 was the best fit i found.
If you want i'll try to find time to dive deeper in this, or pull it in a separate PR, here i mainly wanted to make a quick working fix for the no_small_font issue.
2 participants
Fixes #1784
When
font_size_secondarywas not set, it defaulted to0.55f * font_sizeregardless of theno_small_fontflag.Now, when
no_small_fontis set this default becomes1 * font_size.