shim: Avoid exporting unintended symbols #1668
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll want macros.h for PUBLIC, and it defines an ARRAY_SIZE that we can use. Signed-off-by: Simon McVittie <smcv@collabora.com>
This will allow us to control exports with -fvisibility=hidden. Signed-off-by: Simon McVittie <smcv@collabora.com>
This is intended to be hooked in the process that loaded MangoHud. Signed-off-by: Simon McVittie <smcv@collabora.com>
This avoids accidentally interposing symbols like __dlsym() and eh_hash_elf(). Resolves: flightlessmango#1667 Signed-off-by: Simon McVittie <smcv@collabora.com>
There's no need for these to be referenced outside this translation unit. Signed-off-by: Simon McVittie <smcv@collabora.com>
In fact this has no practical effect right now, because the intentionally-exported symbols are already decorated with `EXPORT_C_` and listed in `mangohud.version`, while the internal-only symbols are declared as local in `mangohud.version`. But this might prevent accidents later. Signed-off-by: Simon McVittie <smcv@collabora.com>
|
Needs testing, I'll try to do that later today. |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shim: Reuse Mesa's macros instead of open-coding
We'll want macros.h for PUBLIC, and it defines an ARRAY_SIZE that we
can use.
shim: Explicitly export forwarding functions
This will allow us to control exports with -fvisibility=hidden.
shim: Explicitly export our dlsym() reimplementation
This is intended to be hooked in the process that loaded MangoHud.
shim: Hide all symbols that are not explicitly public
This avoids accidentally interposing symbols like __dlsym() and
eh_hash_elf().
Resolves: libMangoHud_shim.so exports extra symbols such as eh_hash_elf, __dlsym, get_proc_address #1667
real_dlsym: Make local variables static
There's no need for these to be referenced outside this translation unit.