[SCFD-3899] Added support for mach reynolds input in Aerospace condition #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-flex
force-pushed
the
wiktor/mach_reynolds
branch
from
77ccfd9 to
1140140
Compare
tests/simulation/translator/utils/symmetryBC_param_generator.py
Outdated
Show resolved
Hide resolved
|
This is not a complete fix since for existing simulation.json on S3 cloud, we still store the key-None pairs in Also like I mentioned above. Let's not merge this to 25.2 for now since it is a public version. model_dump fix may introduce bugs. I asked @angranl-flex to add the None-popper in an dedicated PR. We can merge this into develop + 25.5 branch |
flow360/component/simulation/operating_condition/operating_condition.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/operating_condition/operating_condition.py
Outdated
Show resolved
Hide resolved
|
Let's ensure the Reynolds is consistent with Solver definition. @wiktor-flex Could you also update the definition here? |
benflexcompute
approved these changes
May 28, 2025
|
I did hand calculation for |
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
…ion (#961) * added operating condition from mach reynolds to aerospacecondition * black and isort * made exclude_none default in model_dump * fixed test * fixed solver translator unittests * Revert "fixed solver translator unittests" This reverts commit 1140140. * Revert "fixed test" This reverts commit 4137165. * Revert "made exclude_none default in model_dump" This reverts commit 5ece895. * added removing none fields for multi constructor model * small function name change to be more clear * Revert "small function name change to be more clear" This reverts commit 38358f9. * Revert "added removing none fields for multi constructor model" This reverts commit bae5e3d. * fixed conflicts in unittest * black * removed space for consistency * changed density to be calculated from mach and not mach ref * changed reynolds number function to be consistent with solver * added empty line so that list builds correctly * added backslashes to make infty symboo --------- Co-authored-by: Maciej Skarysz <maciej@flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2025
…ion (#961) * added operating condition from mach reynolds to aerospacecondition * black and isort * made exclude_none default in model_dump * fixed test * fixed solver translator unittests * Revert "fixed solver translator unittests" This reverts commit 1140140. * Revert "fixed test" This reverts commit 4137165. * Revert "made exclude_none default in model_dump" This reverts commit 5ece895. * added removing none fields for multi constructor model * small function name change to be more clear * Revert "small function name change to be more clear" This reverts commit 38358f9. * Revert "added removing none fields for multi constructor model" This reverts commit bae5e3d. * fixed conflicts in unittest * black * removed space for consistency * changed density to be calculated from mach and not mach ref * changed reynolds number function to be consistent with solver * added empty line so that list builds correctly * added backslashes to make infty symboo --------- Co-authored-by: Maciej Skarysz <maciej@flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
wiktor-flex
added a commit
that referenced
this pull request
May 28, 2025
…ion (#961) * added operating condition from mach reynolds to aerospacecondition * black and isort * made exclude_none default in model_dump * fixed test * fixed solver translator unittests * Revert "fixed solver translator unittests" This reverts commit 1140140. * Revert "fixed test" This reverts commit 4137165. * Revert "made exclude_none default in model_dump" This reverts commit 5ece895. * added removing none fields for multi constructor model * small function name change to be more clear * Revert "small function name change to be more clear" This reverts commit 38358f9. * Revert "added removing none fields for multi constructor model" This reverts commit bae5e3d. * fixed conflicts in unittest * black * removed space for consistency * changed density to be calculated from mach and not mach ref * changed reynolds number function to be consistent with solver * added empty line so that list builds correctly * added backslashes to make infty symboo --------- Co-authored-by: Maciej Skarysz <maciej@flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
wiktor-flex
added a commit
that referenced
this pull request
May 28, 2025
…ion (#961) (#1103) * added operating condition from mach reynolds to aerospacecondition * black and isort * made exclude_none default in model_dump * fixed test * fixed solver translator unittests * Revert "fixed solver translator unittests" This reverts commit 1140140. * Revert "fixed test" This reverts commit 4137165. * Revert "made exclude_none default in model_dump" This reverts commit 5ece895. * added removing none fields for multi constructor model * small function name change to be more clear * Revert "small function name change to be more clear" This reverts commit 38358f9. * Revert "added removing none fields for multi constructor model" This reverts commit bae5e3d. * fixed conflicts in unittest * black * removed space for consistency * changed density to be calculated from mach and not mach ref * changed reynolds number function to be consistent with solver * added empty line so that list builds correctly * added backslashes to make infty symboo --------- Co-authored-by: Wiktor <wiktor.krzew@flexcompute.com> Co-authored-by: Maciej Skarysz <maciej@flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed operating_condition_from_mach_reynolds function from a standalone one to a classmethod of AerospaceCondition. so that it utilizes MultiConstructorBaseModel.