Skip to content

Bump Pydantic to >=2.8 #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Bump Pydantic to >=2.8 #878

merged 3 commits into from
May 30, 2025

Conversation

benflexcompute
Copy link
Collaborator

No description provided.

@benflexcompute
Copy link
Collaborator Author

Performance diff (translator)
1.06 s (2.11) vs 1.09 (2.7)

The bottle neck is prob not the Pydantic right now.

@benflexcompute
Copy link
Collaborator Author

benflexcompute commented Apr 3, 2025

************* Module flow360.component.case
flow360/component/case.py:856:26: E1133: Non-iterable value self.class.model_fields is used in an iterating context (not-an-iterable)
flow360/component/case.py:894:26: E1133: Non-iterable value self.class.model_fields is used in an iterating context (not-an-iterable)
flow360/component/case.py:1069:26: E1133: Non-iterable value self.class.model_fields is used in an iterating context (not-an-iterable)
************* Module flow360.component.simulation.framework.base_model
flow360/component/simulation/framework/base_model.py:146:19: E1135: Value 'self.class.model_fields' doesn't support membership test (unsupported-membership-test)
flow360/component/simulation/framework/base_model.py:147:24: E1136: Value 'self.class.model_fields' is unsubscriptable (unsubscriptable-object)
flow360/component/simulation/framework/base_model.py:218:25: E1136: Value 'cls.model_fields' is unsubscriptable (unsubscriptable-object)
************* Module flow360.component.simulation.meshing_param.params
flow360/component/simulation/meshing_param/params.py:146:21: E1136: Value 'cls.model_fields' is unsubscriptable (unsubscriptable-object)
flow360/component/simulation/meshing_param/params.py:162:21: E1136: Value 'cls.model_fields' is unsubscriptable (unsubscriptable-object)
flow360/component/simulation/meshing_param/params.py:257:64: E1136: Value 'RotationCylinder.model_fields' is unsubscriptable (unsubscriptable-object)
************* Module flow360.component.simulation.models.volume_models
flow360/component/simulation/models/volume_models.py:209:20: E1136: Value 'cls.model_fields' is unsubscriptable (unsubscriptable-object)


Your code has been rated at 9.96/10 (previous run: 10.00/10, -0.04~

@benflexcompute benflexcompute changed the title Bump pydantic to 2.11 Bump Pydantic to >=2.8 May 30, 2025
@benflexcompute benflexcompute merged commit 672a2d8 into develop May 30, 2025
15 checks passed
@benflexcompute benflexcompute deleted the BenY/BumpPydantic2.11 branch May 30, 2025 15:07
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* Bump pydantic to 2.11

* Bumped Pydantic version and fixed lint and unit test
github-actions bot pushed a commit that referenced this pull request May 30, 2025
* Bump pydantic to 2.11

* Bumped Pydantic version and fixed lint and unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants