fix(): Redefine the surface issue enums

flow360/component/simulation/primitives.py

@@ -401,6 +401,29 @@ def _check_inner_radius_is_less_than_outer_radius(self) -> Self:
 class _SurfaceIssueEnums(str, Enum):
     """
     Enums for indicating that there is something wrong/special about the surface.
+
+    +-------------------+--------------------+--------------------+
+    | If my sub faces...| Issue should be    | Conflict with when |
+    |                   | predicted as       | using              |
+    +-------------------+--------------------+--------------------+
+    | All overlaps with | overlap_half_model_| Auto and Quasi     |
+    | the HalfModel Symm| symmetric          |                    |
+    +-------------------+--------------------+--------------------+
+    | All overlaps with | overlap_quasi_3d_  | Quasi              |
+    | the Non Half      | symmetric          |                    |
+    | Model (the other  |                    |                    |
+    | Q3D) Symm. Or not |                    |                    |
+    | half model at all.|                    |                    |
+    +-------------------+--------------------+--------------------+
+    | Some on HalfModel | overlap_quasi_3d_  | Quasi              |
+    | Symm, Some on Non | symmetric          |                    |
+    | HalfModel Symm    |                    |                    |
+    +-------------------+--------------------+--------------------+
+    | Have some faces   | None               | None               |
+    | elsewhere         |                    |                    |
+    +-------------------+--------------------+--------------------+
+
+
     """
 
     # pylint: disable=invalid-name
@@ -461,6 +484,8 @@ def _will_be_deleted_by_mesher(self, farfield_method: Literal["auto", "quasi-3d"
             return (
                 _SurfaceIssueEnums.overlap_quasi_3d_symmetric
                 in self.private_attribute_potential_issues
+                or _SurfaceIssueEnums.overlap_half_model_symmetric
+                in self.private_attribute_potential_issues
             )
 
         raise ValueError(f"Unknown auto farfield generation method: {farfield_method}.")

flow360/component/simulation/validation/validation_simulation_params.py

@@ -17,9 +17,6 @@
     VolumeOutput,
 )
 from flow360.component.simulation.primitives import (
-    GhostCircularPlane,
-    GhostSphere,
-    GhostSurface,
     _SurfaceEntityBase,
     _VolumeEntityBase,
 )
@@ -299,7 +296,9 @@ def _validate_cht_has_heat_transfer(params):
     return params
 
 
-def _check_complete_boundary_condition_and_unknown_surface(params):
+def _check_complete_boundary_condition_and_unknown_surface(
+    params,
+):  # pylint:disable=too-many-branches
     ## Step 1: Get all boundaries patches from asset cache
 
     current_lvls = get_validation_levels() if get_validation_levels() else []
@@ -318,6 +317,18 @@ def _check_complete_boundary_condition_and_unknown_surface(params):
             for item in asset_boundary_entities
             if item._will_be_deleted_by_mesher(automated_farfield_method) is False
         ]
+        if automated_farfield_method == "auto":
+            asset_boundary_entities += [
+                item
+                for item in params.private_attribute_asset_cache.project_entity_info.ghost_entities
+                if item.name not in ("symmetric-1", "symmetric-2")
+            ]
+        elif automated_farfield_method == "quasi-3d":
+            asset_boundary_entities += [
+                item
+                for item in params.private_attribute_asset_cache.project_entity_info.ghost_entities
+                if item.name != "symmetric"
+            ]
 
     if asset_boundary_entities is None or asset_boundary_entities == []:
         raise ValueError("[Internal] Failed to retrieve asset boundaries")
@@ -344,8 +355,6 @@ def _check_complete_boundary_condition_and_unknown_surface(params):
             ]
 
         for entity in entities:
-            if isinstance(entity, (GhostSurface, GhostSphere, GhostCircularPlane)):
-                continue
             used_boundaries.add(entity.name)
 
     ## Step 3: Use set operations to find missing and unknown boundaries