Skip to content

Update input for MassInflow boundary condition #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2024
Merged

Update input for MassInflow boundary condition #333

merged 4 commits into from
Jun 26, 2024

Conversation

malhardp333
Copy link
Collaborator

@malhardp333 malhardp333 commented Jun 24, 2024 •
edited
Loading

  • Currently, the MassInflow boundary condition requires totalTemperatureRatio in the calculations, but it is not set as required input in the Python API.
  • Hence, it has been added as a required input for this boundary condition, and the corresponding tests have been updated as part of this PR.

benflexcompute
benflexcompute reviewed Jun 24, 2024
View reviewed changes
@benflexcompute
Copy link
Collaborator

@yifan-flex Let's add a memo to incorporate this into Simulation as well.

benflexcompute
benflexcompute reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@benflexcompute benflexcompute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at the unit test:
tests.test_updater.py::test_updater_from_files
and add the MassInflow into one of the solver JSON and make sure the totalTermeratureRatio is properly handled by legacy updater and the new model?

@yifan-flex
Copy link
Contributor

@yifan-flex Let's add a memo to incorporate this into Simulation as well.

It has already been incorporated

@malhardp333 malhardp333 force-pushed the malhar/update_MassInflow_BC_input branch from f893e10 to 43f44a9 Compare June 25, 2024 20:28
@malhardp333 malhardp333 force-pushed the malhar/update_MassInflow_BC_input branch from 43f44a9 to 5b2a7fe Compare June 25, 2024 20:56
@malhardp333 malhardp333 merged commit 9646add into develop Jun 26, 2024
12 checks passed
@malhardp333
Copy link
Collaborator Author

Ben approved the PR and it looks good to merge it, so merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benflexcompute benflexcompute benflexcompute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malhardp333 @benflexcompute @yifan-flex