Remove _type attribute

flow360/component/simulation/framework/base_model.py

@@ -79,7 +79,6 @@ def _handle_file(cls, filename: str = None, **kwargs):
     def __pydantic_init_subclass__(cls, **kwargs) -> None:
         """Things that are done to each of the models."""
         super().__pydantic_init_subclass__(**kwargs)  # Correct use of super
-        cls._add_type_field()
         cls._generate_docstring()
 
     """Sets config for all :class:`Flow360BaseModel` objects.
@@ -439,19 +438,6 @@ def append(self, params: Flow360BaseModel, overwrite: bool = False):
             if is_frozen is None or is_frozen is False:
                 self.__setattr__(key, value)
 
-    @classmethod
-    def _add_type_field(cls) -> None:
-        """Automatically place "type" field with model name in the model field dictionary."""
-
-        # TODO: Check if this _type actually fulfill its goal(?)
-        tag_field = pd.fields.FieldInfo(
-            alias=TYPE_TAG_STR,
-            value=cls.__name__,
-            annotation=Literal[cls.__name__],
-            class_validators=None,
-        )
-        cls.model_fields[TYPE_TAG_STR] = tag_field
-
     @classmethod
     def _generate_docstring(cls) -> str:
         """Generates a docstring for a Flow360 model and saves it to the __doc__ of the class."""

flow360/component/simulation/framework/cached_model_base.py

@@ -6,7 +6,6 @@
 import pydantic as pd
 
 from flow360.component.simulation.framework.base_model import Flow360BaseModel
-from flow360.component.types import TYPE_TAG_STR
 
 
 class CachedModelBase(Flow360BaseModel, metaclass=abc.ABCMeta):
@@ -40,7 +39,6 @@ def __init__(self, **data):
                 pass
         else:
             defaults = {name: field.default for name, field in self.model_fields.items()}
-            defaults.pop(TYPE_TAG_STR)
             self._cached = self.__annotations__["_cached"](
                 **{**defaults, **data}, constructor="default"
             )

tests/simulation/framework/test_base_model_v2.py

@@ -169,11 +169,6 @@ def test_from_json_yaml():
         os.remove(temp_file_name)
 
 
-def test_add_type_field():
-    ## Note: May need to be properly implemented.
-    assert "_type" in BaseModelTestModel.model_fields
-
-
 def test_generate_docstring():
     assert "some_value" in BaseModelTestModel.__doc__