integrate geometry, surface and volume mesher #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feilin-flexcompute
force-pushed
the
feilin/surf_from_geo_i/post
branch
from
8772e49 to
981349d
Compare
feilin-flexcompute
changed the base branch from
feilin/construction/surf_from_geo_i
to
UnderConstruction/SimulationInterface
feilin-flexcompute
force-pushed
the
feilin/surf_from_geo_i/post
branch
from
981349d to
e5e2e8b
Compare
feilin-flexcompute
changed the title
| from flow360 import units as u | ||
|
|
||
|
|
||
| def createBaseParams_airplane(): |
There was a problem hiding this comment.
create_base_params_airplane
also, why do we want this to be in the examples? We already have example on how to create Flow360Params. We can use this as second example. But other examples should not refer to this file. If they need to load example config, it needs to be loaded from file. Every example should be standalone runnable script
There was a problem hiding this comment.
same as ariplane_case.py comment
flow360/component/surface_mesh.py
Outdated
Comment on lines
41
to
47
| class SurfaceMeshFileFormat(Enum): | ||
| """ | ||
| Surface mesh file format | ||
| """ | ||
|
|
||
| UGRID = "lb8.ugrid" | ||
| STL = "stl" |
There was a problem hiding this comment.
a test is needed for this class
maciej-flexcompute
approved these changes
Jun 12, 2024
maciej-flexcompute
merged commit 7d9582d
into
UnderConstruction/SimulationInterface
1 of 4 checks passed
benflexcompute
pushed a commit
that referenced
this pull request
Jun 17, 2024
integrate geometry, surface and volume mesher (#267) * rebase to UnderConstruction/SimulationInterface * use preprod env * lint * fix example * fix * finish csm->case using v1 and v2 * add example: csm geometry -> v2 mesher -> case * finish egads and csm examples * added cylinder * add examples for 3rd party cylinder geometry * fix * address comments of case config in examples * split cylinder into cylinder2d and cylinder3d * split cylinder into 2d and 3d * remove airplane and cylinder params * fix examples for meshing * fix unit test * update Update cached model to store all constructor function arguments (#318) * Update cached model to store all constructor function arguments * Fix pylint * Fix warnings added default values to service bumped version updates added warnings to validate_model service added length units to default params updates to service integration added custom constructor framework (#308) updates fixed volume mesh error added private_attribute_constructor and private_attribute_input_cache Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.