Om6wing diverged but likely because some param not properly set #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added strucuture and interface for Simulation object update design with some grouping and renaming, added user_stories to fill in Added example FORMAT Added the diagram Added stripped Flow360BaseModel Removed allow_but_remove WIP on updating the BaseModel to pydantic V2 WIP Add more docstring for details * Updated the base model to V2 in simulation * Fix unit test * Lint * fresh install * Add CI to UnderConstruction/SimulationInterface * Try again * Try again * Try again --------- Co-authored-by: benflexcompute <ben@flexcompute.com>
benflexcompute
commented
May 7, 2024
There was a problem hiding this comment.
Basically just copy paste.
benflexcompute
commented
May 7, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from flow360.component.simulation.base_model import Flow360BaseModel | |||
|
|
|||
| from .zones import BoxZone, CylindricalZone | |||
| from .volumes import BoxZone, CylindricalZone | |||
There was a problem hiding this comment.
File/folder organization is messed up. Need some sorting out.
benflexcompute
commented
May 7, 2024
There was a problem hiding this comment.
Mostly copy paste
benflexcompute
commented
May 7, 2024
| volume_mesh_draft: Optional[VolumeMeshDraft] = None | ||
|
|
||
| # pylint: disable=redefined-builtin | ||
| def __init__( |
There was a problem hiding this comment.
Major change here. Added volume_mesh_draft. We need some discussion.
benflexcompute
commented
May 7, 2024
flow360/component_v2/case.py
Outdated
There was a problem hiding this comment.
Similar to what I did for volumeMesh
benflexcompute
commented
May 7, 2024
flow360/component_v2/folder.py
Outdated
There was a problem hiding this comment.
Basically just copy paste
benflexcompute
commented
May 7, 2024
There was a problem hiding this comment.
Basically just copy paste
benflexcompute
commented
May 7, 2024
flow360/component_v2/validator.py
Outdated
There was a problem hiding this comment.
Dummy, validation is skipped for now.
Base automatically changed from
UnderConstruction/SimulationInterface
to
develop
August 2, 2024 14:32
|
Not relevant anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.