Skip to content

adjusted report related docstrings and added report init #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2025
Merged

adjusted report related docstrings and added report init #1159

merged 4 commits into from
Jun 13, 2025

Conversation

wiktor-flex
Copy link
Collaborator

@wiktor-flex wiktor-flex commented Jun 12, 2025 •
edited
Loading

This is done in order to include Report related things in documentation.

  • changed docstrings of multiple classes
  • added init file to report with chosen report classes and added it into flow360 init

@wiktor-flex wiktor-flex self-assigned this Jun 12, 2025
@wiktor-flex wiktor-flex marked this pull request as draft June 12, 2025 12:36
@wiktor-flex wiktor-flex marked this pull request as ready for review June 12, 2025 14:32
piotrkluba
piotrkluba approved these changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@piotrkluba piotrkluba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

@wiktor-flex wiktor-flex merged commit 8ba5fb3 into develop Jun 13, 2025
30 checks passed
@wiktor-flex wiktor-flex deleted the wiktor/report_docs branch June 13, 2025 13:40
github-actions bot pushed a commit that referenced this pull request Jun 13, 2025
@wiktor-flex
adjusted report related docstrings and added report init (#1159)
b03a7af 
* adjusted report related docstrings and added report init

* lint fixes

* moved field descriptions from docstrings to pydantic Fields

* black
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Jun 13, 2025
@wiktor-flex
adjusted report related docstrings and added report init (#1159)
0370549 
* adjusted report related docstrings and added report init

* lint fixes

* moved field descriptions from docstrings to pydantic Fields

* black
@github-actions github-actions bot mentioned this pull request Jun 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrkluba piotrkluba piotrkluba approved these changes

@maciej-flexcompute maciej-flexcompute Awaiting requested review from maciej-flexcompute

Assignees

@wiktor-flex wiktor-flex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktor-flex @piotrkluba