Skip to content

changed betdisk example to use xrotor instead of json file #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

changed betdisk example to use xrotor instead of json file #1123

merged 1 commit into from
Jun 5, 2025

Conversation

wiktor-flex
Copy link
Collaborator

  • removed unnecessary information from the file
  • added xrotor file to the examples assets
  • removed disk0 and cylinder0 from examples assets
  • changed the BETDisk input method to use from_xrotor

There are some discrepancies in the results between original version and this one.

  • the resulting BETDisk using from_xrotor has more alphas defined between -10 and 10
  • slight differences in twists and chords (might be due to translation)
  • original CL = 0.125, new CL = 1
  • original CD = 0.0045, new CD = 0.0031

@wiktor-flex wiktor-flex requested a review from piotrkluba June 4, 2025 10:54
@wiktor-flex wiktor-flex self-assigned this Jun 4, 2025
@wiktor-flex wiktor-flex changed the title changed betdisk example to use xrotor file instead of json changed betdisk example to use xrotor instead of json file Jun 4, 2025
piotrkluba
piotrkluba approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@piotrkluba piotrkluba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it runs, everything is great

@wiktor-flex wiktor-flex merged commit e70b7cf into develop Jun 5, 2025
15 checks passed
@wiktor-flex wiktor-flex deleted the wiktor/rotorcraft branch June 5, 2025 08:53
github-actions bot pushed a commit that referenced this pull request Jun 5, 2025
@wiktor-flex
changed betdisk example to use xrotor file instead of json (#1123)
7ccd201
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 5, 2025
@wiktor-flex
changed betdisk example to use xrotor file instead of json (#1123)
d88bb6d
@github-actions github-actions bot mentioned this pull request Jun 5, 2025
Merged
@wiktor-flex wiktor-flex mentioned this pull request Jun 5, 2025
Merged
wiktor-flex added a commit that referenced this pull request Jun 5, 2025
@github-actions @wiktor-flex
changed betdisk example to use xrotor file instead of json (#1123) (#…
401ede0 
…1134)

Co-authored-by: Wiktor <wiktor.krzew@flexcompute.com>
wiktor-flex added a commit that referenced this pull request Jun 5, 2025
@github-actions @wiktor-flex
changed betdisk example to use xrotor file instead of json (#1123) (#…
a26d36b 
…1133)

Co-authored-by: Wiktor <wiktor.krzew@flexcompute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrkluba piotrkluba piotrkluba approved these changes

@maciej-flexcompute maciej-flexcompute Awaiting requested review from maciej-flexcompute

Assignees

@wiktor-flex wiktor-flex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktor-flex @piotrkluba