Exclude pseudo/time step related columns when computing the average of forces #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benflexcompute
approved these changes
Jun 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
…f forces (#1116) * Exclude pseudo/time step related columns when computing the average of forces * fix unit test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
…f forces (#1116) * Exclude pseudo/time step related columns when computing the average of forces * fix unit test
angranl-flex
added a commit
that referenced
this pull request
Jun 3, 2025
…f forces (#1116) * Exclude pseudo/time step related columns when computing the average of forces * fix unit test
angranl-flex
added a commit
that referenced
this pull request
Jun 3, 2025
…g the average of forces (#1122) * results folder back under linting * Exclude pseudo/time step related columns when computing the average of forces (#1116) * Exclude pseudo/time step related columns when computing the average of forces * fix unit test * Fix unit test --------- Co-authored-by: benflexcompute <ben@flexcompute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that the time_units column cannot be handled correctly when computing the results' average for an unsteady simulation.