-
Notifications
You must be signed in to change notification settings - Fork 7
[FL-727][FLPY-3] Support group by boundary and by body in surface force csv result model #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benflexcompute
approved these changes
May 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
…esult model (#1084) * Add by_boundary_condition function * Add support to group result by body group * Add implementation to create mapping between body group and face group names * Add value error, typehint and update docstring * add unit test * Fix bug in the script * Add unit test * Address comments * Enforce entity_groups to be a required field * self review * Fix pylint * Address comments --------- Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
…esult model (#1084) * Add by_boundary_condition function * Add support to group result by body group * Add implementation to create mapping between body group and face group names * Add value error, typehint and update docstring * add unit test * Fix bug in the script * Add unit test * Address comments * Enforce entity_groups to be a required field * self review * Fix pylint * Address comments --------- Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.