Pylint Fix for expression branch
#1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benflexcompute
commented
May 21, 2025
| @@ -18,27 +18,13 @@ def _unit_list(): | |||
|
|
|||
|
|
|||
| def _import_flow360(name: str) -> Any: | |||
| import flow360 as fl | |||
There was a problem hiding this comment.
These are no longer needed? They cause cyclic import.
|
|
||
| return u | ||
|
|
||
| if name == "control": |
There was a problem hiding this comment.
Same here. Do we rely on the context/resolver to parse "solution."?
There was a problem hiding this comment.
Since it is always used from the flow360 client context those symbols will be already imported, so I think evaluation should work fine even with those removed... Overall we want to rely on context/resolver for security reasons - so that we only expose the whitelisted symbols and nothing else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.