finufft: update to 2.4 #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
dfm
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our vendored finufft dependency to 2.4, and remove some references to deprecated functionality (
FINUFFT_CUDA_ARCHITECTURES,chkbnds).Technically the
chkbndsremoval breaks the API, so perhaps now is the time for v1.0? Or we could keepchkbnds, it's a no-op (finufft removed it, though).Building and testing this was actually quite hard (even with old finufft). I was running into all sorts of low-level runtime errors unless the CUDA/cuDNN versions were in a very narrow range. According to the JAX docs, I think it's supposed to work with a much broader range. I ended up using a dev container so I could match the versions better, which wasn't such a bad solution. I've added that config to the repo; some users may find it useful, too, especially until we start building CUDA wheels.