fix: rooms and size on kleinanzeigen #686
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks so much for this - this looks great. I have one comment, but besides that I'm happy to merge |
codders
reviewed
Aug 10, 2025
| 'title': title_elem.text.strip(), | ||
| 'price': price, | ||
| 'size': size, | ||
| 'size': size + "m²", |
There was a problem hiding this comment.
I'm not so sure about putting the "m²" here. I would prefer the exposé just to have the raw data and add the unit in the message template. Is there a reason you want to have the unit here in the details?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some problems with Kleinanzeigen lately, so I decided to have a look.
The rooms and apartment size weren't extracted correctly.
I've updated it, so the data is now extracted from the new string it is in.
(Also an add to the .gitignore since me and some other people I know use .venv for their virtual environments. I can remove that if you want)