Potential fix for code scanning alert no. 2: Use of string after lifetime ends #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested changes
Jun 30, 2025
|
Now the CI starts to fail when downloading https://github.com/kinvolk/seismograph/archive/flatcar-master.zip, which has nothing to do with this PR. That happens because of the recent branch renaming. |
dongsupark
force-pushed
the
fix-string-after-lifetime
branch
from
0cbb3cb to
6513e95
Compare
…time ends Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Get(index) returns a copy of a string. That copy is kept alive by the const reference until the end of the GetCStr function. When the GetCStr function returns, the copy is destroyed (and so is its char buffer), so returned pointer to the char buffer becomes dangling. Suggested-by: Krzesimir Nowak <knowak@microsoft.com>
dongsupark
force-pushed
the
fix-string-after-lifetime
branch
from
6513e95 to
547c09a
Compare
krnowak
approved these changes
Jul 10, 2025
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 10, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46.
1 task
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 16, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46. Signed-off-by: Dongsu Park <dongsu@dpark.io>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 16, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46. Signed-off-by: Dongsu Park <dongsu@dpark.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/flatcar/update_engine/security/code-scanning/2
To fix the issue, we need to ensure that the lifetime of the
std::stringobject returned byGet(index)is extended so that the pointer returned byc_str()remains valid. The best way to achieve this is to store thestd::stringobject in a local variable within theGetCStrmethod and return the pointer to its character array. This ensures that thestd::stringobject outlives the call toc_str().Changes will be made to the
GetCStrmethod in theUrlTermsclass. Specifically:Get(index)in a local variable.c_str()on the local variable and return the pointer.No additional imports or dependencies are required for this fix.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.