Potential fix for code scanning alert no. 3: Unsigned difference expression compared to zero #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession compared to zero Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
krnowak
approved these changes
Jun 30, 2025
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 10, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46.
1 task
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 16, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46. Signed-off-by: Dongsu Park <dongsu@dpark.io>
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jul 16, 2025
Bump coreos-base/update_engine to 2025-07-10. Pulls in flatcar/update_engine#44, flatcar/update_engine#45, flatcar/update_engine#46. Signed-off-by: Dongsu Park <dongsu@dpark.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/flatcar/update_engine/security/code-scanning/3
To fix the issue, we need to avoid unsigned subtraction in the loop condition. Instead of
count - bytes_written > 0, we can directly comparebytes_writtenwithcountusingbytes_written < count. This approach avoids the risk of underflow and achieves the same logical result.The fix involves replacing the condition on line 21 with
bytes_written < count. This change ensures that the loop behaves correctly regardless of the values ofcountandbytes_written.Suggested fixes powered by Copilot Autofix. Review carefully before merging.