chore: refactor get_payload() function #218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
karankurbur
force-pushed
the
PROTO-863
branch
2 times, most recently
from
22d8849 to
8d94e70
Compare
Dzejkop
reviewed
May 15, 2025
| @@ -577,82 +577,143 @@ impl RollupBoostServer { | |||
| payload_id: PayloadId, | |||
| version: Version, | |||
| ) -> RpcResult<OpExecutionPayloadEnvelope> { | |||
| // Start fetching L2 payload early (we'll always need it) | |||
There was a problem hiding this comment.
Unless a tokio task is spawned under the hood this future will only begin resolving once it's .awaited on. Consider wrapping it in a tokio::spawn to start resolving immediately
There was a problem hiding this comment.
It's being joined below though, so that should be fine.
| @@ -577,82 +577,143 @@ impl RollupBoostServer { | |||
| payload_id: PayloadId, | |||
| version: Version, | |||
| ) -> RpcResult<OpExecutionPayloadEnvelope> { | |||
| // Start fetching L2 payload early (we'll always need it) | |||
There was a problem hiding this comment.
It's being joined below though, so that should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor get_payload() by splitting into explicit functions for each step