Skip to content

Show error when both use-native-reth secondary-el flags are enabled #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Show error when both use-native-reth secondary-el flags are enabled #75

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4ab121
panic when both use-native-reth secondary-el flags are enabled
simon0x1800 Mar 25, 2025
0c03d44
Merge branch 'flashbots:main' into l1-incompatible-flags
simon0x1800 Mar 26, 2025
ee6f37b
Add support for both flags
simon0x1800 Mar 26, 2025
7406a13
remove unnecessary comment
simon0x1800 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/recipe_l1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,16 @@ func (l *L1Recipe) Apply(ctx *ExContext, artifacts *Artifacts) *Manifest {
// we are going to use the cl-proxy service to connect the beacon node to two builders
// one the 'el' builder and another one the remote one
elService = "cl-proxy"

primaryBuilder := "el"
if l.useNativeReth {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be happening already because the docker runtime should resolve this reference.

// When using native Reth, we need to connect to the host machine
// instead of the Docker service name "el"
primaryBuilder = "host.docker.internal:8545"
}

svcManager.AddService("cl-proxy", &ClProxy{
PrimaryBuilder: "el",
PrimaryBuilder: primaryBuilder,
SecondaryBuilder: fmt.Sprintf("http://localhost:%d", l.secondaryELPort),
})
} else {
Expand Down