Skip to content

Fix/reserve port #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Fix/reserve port #114

merged 3 commits into from
Apr 25, 2025

Conversation

ferranbt
Copy link
Collaborator

This PR fixes two issues in reservePort:

  • It did not consider the type of protocol when checking if the ports were available.
  • It did not consider whether the host ports were going to be binded at 0.0.0.0 or 127.0.0.1.

@ferranbt ferranbt mentioned this pull request Apr 25, 2025
Merged
@ferranbt ferranbt merged commit 242d8ec into main Apr 25, 2025
7 checks passed
@ferranbt ferranbt deleted the fix/reserve-port branch May 24, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferranbt