Skip to content

Add playground session id #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Add playground session id #113

merged 1 commit into from
Apr 25, 2025

Conversation

ferranbt
Copy link
Collaborator

This PR adds a session ID feature to the builder-playground to better track containers across different running instances. The key changes include:

  • Adding a unique session ID (UUID) to each LocalRunner instance
  • Using this session ID in container labels with playground.session={sessionID}
  • Modifying container filtering to use the session ID instead of just the generic "playground=true" label
  • Updating the cleanup process to only stop containers belonging to the specific session

These changes solve the problem of having multiple playground instances running simultaneously by ensuring each instance only manages its own containers. Previously, all containers shared the same "playground=true" label, which could lead to one instance inadvertently affecting containers from another instance during cleanup operations.

@ferranbt ferranbt merged commit 49e3782 into main Apr 25, 2025
7 checks passed
@ferranbt ferranbt deleted the feat/session-id-docker branch May 24, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant