Skip to content

chore: minor admin frontend cleanup #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Feb 11, 2025

Companion to flarum/framework#4188

Fixes #0000

Changes proposed in this pull request:

  • Remove unused classname to match structure of core, ensuring the new Button inside the dropdown is left aligned
  • Increase type safety
  • Add a11y titles
  • Ditch username() helper inside translations (reason being [object Object] is shown in the translation when in use, did also a brief dive into the codebase and didn't find any other occasion where the username() helper was used inside a translation).
  • Refactor translations to better match structure of core

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

This change left aligns the button in the dropdown
* Ditch `username()` for use in translations
* Rename translation keys to better match structure of core
@DavideIadeluca DavideIadeluca changed the title chore: chore: minor admin frontend cleanup Feb 11, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 11, 2025 07:59
@SychO9 SychO9 merged commit cefe772 into flarum:2.x Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants