Skip to content

[1.x] fix: remove redefinition of github token #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented May 28, 2025

Fixes #0000
Fixes a regression introduced in #4078 in relation to composer auth not working anymore.

It appears as if explicitly defining it in the job interferes with how actions such as shivammathur/setup-php@v2 authenticate with composer.

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

Fixes a regression introduced in flarum#4078 in relation to composer auth.

It appears as if explicitly defining it in the job interferes with how actions such as shivammathur/setup-php@v2 authenticate with composer.
@DavideIadeluca DavideIadeluca changed the title fix: remove redefinition of github token [1.x] fix: remove redefinition of github token May 28, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review May 28, 2025 07:05
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner May 28, 2025 07:05
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift fix @DavideIadeluca

@imorland imorland merged commit dcbba5f into flarum:1.x May 28, 2025
321 checks passed
@imorland imorland deleted the di/fix-composer-auth branch May 28, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants