Skip to content

[1.x] chore: update JS deps #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

[1.x] chore: update JS deps #4204

merged 2 commits into from
Mar 12, 2025

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 1.8.10 milestone Mar 12, 2025
@imorland imorland added the dependencies Pull requests that update a dependency file label Mar 12, 2025
@imorland imorland changed the title chore: output of yarn upgrade [1.x] chore: update JS deps Mar 12, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review March 12, 2025 09:46
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner March 12, 2025 09:46
imorland
imorland approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure as to why prettier wanted this change, will put it down to deps update.

@imorland imorland merged commit f54d972 into flarum:1.x Mar 12, 2025
322 checks passed
@imorland imorland deleted the di/js-deps branch March 12, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.8.10
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideIadeluca @imorland