Skip to content

feat: actions dropdown in admin user list #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions framework/core/js/src/admin/components/UserListPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import app from '../../admin/app';

import LoadingIndicator from '../../common/components/LoadingIndicator';
import Button from '../../common/components/Button';
import Dropdown from '../../common/components/Dropdown';

import listItems from '../../common/helpers/listItems';

Expand Down Expand Up @@ -363,17 +364,18 @@ export default class UserListPage extends AdminPage {
);

columns.add(
'editUser',
'userActions',
{
name: app.translator.trans('core.admin.users.grid.columns.edit_user.title'),
name: app.translator.trans('core.admin.users.grid.columns.user_actions.title'),
content: (user: User) => (
<Button
className="Button UserList-editModalBtn"
title={app.translator.trans('core.admin.users.grid.columns.edit_user.tooltip', { username: user.username() })}
onclick={() => app.modal.show(() => import('../../common/components/EditUserModal'), { user })}
<Dropdown
className="User-controls"
buttonClassName="Button Button--icon Button--flat"
menuClassName="Dropdown-menu--right"
icon="fas fa-ellipsis-h"
>
{app.translator.trans('core.admin.users.grid.columns.edit_user.button')}
</Button>
{this.userActionItems(user).toArray()}
</Dropdown>
),
},
-90
Expand All @@ -382,6 +384,23 @@ export default class UserListPage extends AdminPage {
return columns;
}

userActionItems(user: User): ItemList<Mithril.Children> {
const items = new ItemList<Mithril.Children>();

items.add(
'editUser',
<Button
icon="fas fa-pencil-alt"
title={app.translator.trans('core.admin.users.grid.columns.user_actions.edit_user.tooltip', { username: user.displayName() }, true)}
onclick={() => app.modal.show(() => import('../../common/components/EditUserModal'), { user })}
>
{app.translator.trans('core.admin.users.grid.columns.user_actions.edit_user.button')}
</Button>
);

return items;
}

headerInfo() {
return {
className: 'UserListPage',
Expand Down
11 changes: 6 additions & 5 deletions framework/core/locale/core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,6 @@ core:
display_name:
title: Display name

edit_user:
button: => core.ref.edit
title: => core.ref.edit_user
tooltip: Edit {username}

email:
title: => core.ref.email
visibility_hide: Hide email address
Expand All @@ -376,6 +371,12 @@ core:
join_time:
title: Joined

user_actions:
title: Actions
edit_user:
button: => core.ref.edit
tooltip: Edit {username}

user_id:
title: ID

Expand Down
Loading