Skip to content

fix(core, tags): resolve a11y warnings in Admin Frontend #4184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Feb 10, 2025

2.x port of #4114.

Progresses #4060

Changes proposed in this pull request:
Fixes a11y warnings in admin frontend as done on 1.x, also adds aria labels for new Pagination Buttons

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title fix(core, tags): resolve a11y warnings in Admin Frontend fix(core, tags): resolve a11y warnings in Admin Frontend Feb 10, 2025
@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 10, 2025 15:10
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner February 10, 2025 15:10
@DavideIadeluca DavideIadeluca marked this pull request as draft February 11, 2025 06:10
@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 11, 2025 08:28
@SychO9 SychO9 added this to the 2.0.0-beta.3 milestone Feb 11, 2025
@SychO9 SychO9 added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Feb 11, 2025
@SychO9 SychO9 merged commit a34a5d4 into flarum:2.x Feb 11, 2025
21 checks passed
@DavideIadeluca DavideIadeluca deleted the di/fix-a11y-in-admin branch February 17, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants